Skip to content

[No QA] Docs updates for E/A#101142 Members selection clears when search changes - #101271

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsMembersSelectionClearsOnSearch
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsMembersSelectionClearsOnSearch

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Clear the Members table selection when the search string changes, which removed shouldPreserveSelectionOnSearch from the Members table. The member selection now clears whenever the Find member search string changes — including when the search is cleared — instead of surviving the search.

docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md said nothing about how selection interacts with search or filters, so an admin who selects members inside a search and then clears it has no documented explanation for the checkboxes emptying. This adds that note under Remove Multiple Members.

While in that section, the steps also referenced UI that no longer exists. I verified every label against dev NewDot web on the Members page and corrected them:

Was Now
Click the green dropdown arrow in the top-right Click the selected count button in the top-right — for example, 2 selected
Choose Remove Member(s) Select Remove members (reads Remove member for a single selection)
"combine role filters with the search bar" "combine role filters with the Find member search box"

Also documents the Select all header checkbox and the fact that you can't select your own row, and adds matching keywords to the front matter.

Applies docs/HELPSITE_NAMING_CONVENTIONS.md (exact, bolded UI labels; no paraphrased or invented control names) and docs/HELP_AUTHORING_GUIDELINES.md. This is a targeted edit to one existing article, so it keeps that article's current heading structure rather than restructuring it.

Fixed Issues

Docs follow-up for #101142, which fixed:

$ #100991
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".

This PR changes Markdown under docs/articles only — there is no app code to exercise. What needs checking is that the documented behavior and labels match the product:

  1. Open the updated article preview and read the Remove Multiple Members section.
  2. In New Expensify, go to Workspaces > [Workspace Name] > Members.
  3. Confirm the search box placeholder reads Find member, the header checkbox is Select all, and the unselected primary button reads Invite member.
  4. Select two members and confirm the top-right button reads 2 selected and its menu offers Remove members; with one member selected, confirm it reads Remove member.
  5. Search for a subset, press Select all, then clear the search. Confirm every checkbox is unchecked and the button returns to Invite member — the behavior the new note describes.
  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR only changes help site Markdown and ships no app code, so there is no offline behavior to test.

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

No app code changed. These are the label and behavior checks I ran on dev NewDot web to source the wording in this article.

What was verified Screenshot
Find member search box, Filters button, and the green Invite member button Members page showing the Find member search box, Filters button and green Invite member button
2 selected button and its Remove members menu item Two members selected showing the 2 selected button and the Remove members menu item
Selection made inside a search (1 selected) Search filtered to one member with that row selected and the header showing 1 selected
Search cleared — every checkbox unchecked, button back to Invite member After clearing the search all rows are unchecked and the button is back to Invite member

@linhvovan29546, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…ilters change

Follows E/A#101142, which removed shouldPreserveSelectionOnSearch from the Members table so the selection now clears whenever the search string changes. Also corrects the Remove Multiple Members steps to use the real UI labels verified against dev NewDot web.

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 16, 2026 00:24
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 16, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#101142 Members selection clears when search changes [No QA] Docs updates for E/A#101142 Members selection clears when search changes Sep 16, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b5d73680.helpdot.pages.dev ⚡️

Updated articles:

@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot Make the PR ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I couldn't mark this PR as ready for review. My environment blocked the gh pr ready command in this run, so the PR is still a draft.

The PR itself looks ready:

  • All checks pass except Check independent approval, which is expected before review.
  • linhvovan29546 is the assignee, so you can mark it ready yourself. Click Ready for review at the bottom of the PR.

Before you do, you may want to delete the two // TODO: **The human co-author** must fill out… lines in the Tests and QA Steps sections. The steps under them are already filled in.


view run

@stephanieelliott

Copy link
Copy Markdown
Contributor

Consolidating to #101958 to avoid conflicts

truph01 pushed a commit to truph01/App that referenced this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants